[all-commits] [llvm/llvm-project] 8ee442: [libc++] Re-apply "Build GoogleBenchmark directly ...

[Louis Dionne via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8ee4426e3dae25d155d102d20f7cd395bd035174
      https://github.com/llvm/llvm-project/commit/8ee4426e3dae25d155d102d20f7cd395bd035174
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2026-09-24 (Thu, 24 Sep 2026)

  Changed paths:
    M libcxx/test/CMakeLists.txt
    R libcxx/test/benchmarks/CMakeLists.txt
    A libcxx/test/benchmarks/lit.local.cfg
    M libcxx/test/configs/harness-configuration.cfg.in
    M libcxx/utils/libcxx/test/config.py
    M libcxx/utils/libcxx/test/format.py
    A libcxx/utils/libcxx/test/googlebenchmark.py
    M libcxx/utils/libcxx/test/params.py
    M libcxxabi/test/CMakeLists.txt
    M libcxxabi/test/configs/cmake-bridge.cfg.in
    M libunwind/test/CMakeLists.txt
    M libunwind/test/configs/cmake-bridge.cfg.in

  Log Message:
  -----------
  [libc++] Re-apply "Build GoogleBenchmark directly from Lit" (#225856)

Previously, we would build GoogleBenchmark against the just-built
library, not against the library being tested. When testing historical
versions of libc++ or other standard libraries, this breaks. So instead
of building Google Benchmark against the just-built library in CMake, do
it from Lit as part of the test suite's configuration.

I'm not a huge fan of using Lit as a poor man's build system and we
should make the CMake test suite self-contained, however this is a step
in the right direction and it removes a major coupling between the test
suite and the regular libc++ build.

This patch re-applies 1bfe9893f3dc which was reverted in 62ea87e542c3
because it broke the Fuchsia bots. This new version of the patch also
threads through the path to the CMake program being used, the CMake
generator and the CMake "make program" from the top-level CMake to the
test-suite, so that the Google Benchmark build can inherit what the
top-level CMake is using.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications