[all-commits] [llvm/llvm-project] 12f5b2: [InstCombine] Directly add negated instructions to...

Nikita Popov via All-commits all-commits at lists.llvm.org
Thu Sep 24 04:45:57 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 12f5b245fa09c91317bf74e5e207a2a7da661407
      https://github.com/llvm/llvm-project/commit/12f5b245fa09c91317bf74e5e207a2a7da661407
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2026-09-24 (Thu, 24 Sep 2026)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineNegator.cpp

  Log Message:
  -----------
  [InstCombine] Directly add negated instructions to the worklist (#226118)

This code was doing something really confusing: Resetting the
insertion point and debug location and then inserting the
instructions -- which should be a no-op. It turns out that the
purpose of this code is to invoke the InstCombine IRBuilder
insertion callback, which will add these instructions to the
worklist.

Instead of going through these contortions, directly add the
new instructions to the worklist.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list