[all-commits] [llvm/llvm-project] 4aa4a6: [PDB] Correctly read/write the named stream map's ...

[Hans Wennborg via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4aa4a6d9e82dcef3e6a1c9ae249a144e60384f52
      https://github.com/llvm/llvm-project/commit/4aa4a6d9e82dcef3e6a1c9ae249a144e60384f52
  Author: Hans Wennborg <hans at hanshq.net>
  Date:   2026-09-24 (Thu, 24 Sep 2026)

  Changed paths:
    M llvm/lib/DebugInfo/PDB/Native/InfoStreamBuilder.cpp
    M llvm/lib/DebugInfo/PDB/Native/NamedStreamMap.cpp
    M llvm/test/DebugInfo/PDB/pdbdump-raw-bytes.test
    M llvm/test/tools/llvm-pdbutil/explain-pdb-stream.test

  Log Message:
  -----------
  [PDB] Correctly read/write the named stream map's niMac value (#225729)

The serialization of a PDB stream's named stream map ends with an
integer value, NMTNI::niMac in the microsoft-pdb code.

Since 05d5e6136f5a3f5de28ae64077200bbdc2cacfb4, LLVM was writing this
out as an undocumented zero between the named streams map and feature
codes, and reading it as an unknown/ignored feature code.

The actual value doesn't seem particularly important, but it's better to
read/write these explicitly, and it should not be read as a feature
code.

This fixes one of the issues in
https://github.com/llvm/llvm-project/issues/206120



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications