[all-commits] [llvm/llvm-project] 6454f1: [mlir-c] Fix testDialectMaterializeConstant review...

Maksim Levental via All-commits all-commits at lists.llvm.org
Wed Sep 23 20:42:31 PDT 2026


  Branch: refs/heads/users/makslevental/mlir-c-dialect-materialize-constant
  Home:   https://github.com/llvm/llvm-project
  Commit: 6454f19fad7f347165313ac0cd9938a8529f9506
      https://github.com/llvm/llvm-project/commit/6454f19fad7f347165313ac0cd9938a8529f9506
  Author: Maksim Levental <maksim at Maksims-MacBook-Pro.local>
  Date:   2026-09-23 (Wed, 23 Sep 2026)

  Changed paths:
    M mlir/test/CAPI/rewrite.c

  Log Message:
  -----------
  [mlir-c] Fix testDialectMaterializeConstant review comments

Correct the misleading comment about the func dialect (it does have a
constant materializer; it just declines an i32 IntegerAttr), and assert
the documented insertion-point contract: the op lands in the current
insertion block and the rewriter's insertion point is preserved.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list