[all-commits] [llvm/llvm-project] 36e1df: [lldb][NativePDB] don't assert when a public symbo...

[Charles Zablit via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 36e1dfd58c07b213a5d57095247629f63381ed75
      https://github.com/llvm/llvm-project/commit/36e1dfd58c07b213a5d57095247629f63381ed75
  Author: Charles Zablit <c_zablit at apple.com>
  Date:   2026-09-23 (Wed, 23 Sep 2026)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/corrupt-public-offset.py
    A lldb/test/Shell/SymbolFile/NativePDB/public-symbol-offset-past-section-end.cpp

  Log Message:
  -----------
  [lldb][NativePDB] don't assert when a public symbol sits past its section (#225734)

Fix an assertion failure in `SymbolFileNativePDB::AddSymbols` when a
public symbol's offset doesn't agree with its section's size (happens
with real-world PDBs after incremental linking). Instead of asserting,
we now log and skip the size estimate for that symbol.

Also adds a regression test that crafts such a PDB and checks lldb
doesn't crash.

This fixes crashes in swiftlang.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications