[all-commits] [llvm/llvm-project] 0ceb86: [ABI] Thread alloca address space through getNatur...

[Chaitanya via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0ceb8668fa909fe48f4d74869817e78d0f325169
      https://github.com/llvm/llvm-project/commit/0ceb8668fa909fe48f4d74869817e78d0f325169
  Author: Chaitanya <Krishna.Sankisa at amd.com>
  Date:   2026-09-23 (Wed, 23 Sep 2026)

  Changed paths:
    M llvm/include/llvm/ABI/TargetInfo.h
    M llvm/lib/ABI/TargetInfo.cpp
    M llvm/lib/ABI/Targets/AArch64.cpp
    M llvm/lib/ABI/Targets/BPF.cpp
    M llvm/lib/ABI/Targets/X86.cpp
    M llvm/unittests/ABI/AArch64TargetInfoTest.cpp
    M llvm/unittests/ABI/TargetInfoTest.cpp
    M llvm/unittests/ABI/X86TargetInfoTest.cpp

  Log Message:
  -----------
  [ABI] Thread alloca address space through getNaturalAlignIndirect (#225301)

Summary:
- Indirect arguments were always emitted in address space 0, dropping
the target's alloca address space.
- Mirror classic `ABIInfo::getNaturalAlignIndirect` by making the
address space explicit and sourcing it from a target hook, so
targets whose stack lives in a non-default space (e.g. AMDGPU private)
are lowered correctly.

Changes:
- `TargetInfo.h`: add `getAllocaAddrSpace()` (default 0), the
ABI-library analogue of `DataLayout::getAllocaAddrSpace()`. Make
AddrSpace a required parameter of `getNaturalAlignIndirect`.
- `TargetInfo.cpp`: pass AddrSpace into `ArgInfo::getIndirect`.
- X86/AArch64/BPF: pass `getAllocaAddrSpace()` at all
`getNaturalAlignIndirect` call sites.
- X86/AArch64 unit tests: assert the indirect address space is 0.

Assisted by: claude opus 4.8



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications