[all-commits] [llvm/llvm-project] 264320: [lldb-dap] Fix global-scope evaluate always routin...

[Nathan Fusselman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2643205b93aa72864b2ac0cd0ae8047bc8048baf
      https://github.com/llvm/llvm-project/commit/2643205b93aa72864b2ac0cd0ae8047bc8048baf
  Author: Nathan Fusselman <nathanfusselman at icloud.com>
  Date:   2026-09-22 (Tue, 22 Sep 2026)

  Changed paths:
    M lldb/test/API/tools/lldb-dap/evaluate/TestDAP_evaluate.py
    M lldb/test/API/tools/lldb-dap/evaluate/main.cpp
    M lldb/tools/lldb-dap/DAP.cpp

  Log Message:
  -----------
  [lldb-dap] Fix global-scope evaluate always routing to command interpreter (#225243)

DetectReplMode returned Command unconditionally when there was no frame,
since it couldn't check FindVariable without one. A frameless evaluate
(no frameId, e.g. `(int)getpid()`) was always treated as an unknown
command instead of an expression.

Fall back to SBTarget::FindFirstGlobalVariable when there's no frame:
DAP::target is valid independent of frame, so globals/statics can still
be checked without one.

rdar://187884135



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications