[all-commits] [llvm/llvm-project] 9a7a66: [offload-arch] Do not print "-strict" if it is dis...

A. Cauble via All-commits all-commits at lists.llvm.org
Tue Sep 22 10:14:35 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9a7a665cbe2a9e59403bcfb59ac6c1294370e8ee
      https://github.com/llvm/llvm-project/commit/9a7a665cbe2a9e59403bcfb59ac6c1294370e8ee
  Author: A. Cauble <accauble at users.noreply.github.com>
  Date:   2026-09-22 (Tue, 22 Sep 2026)

  Changed paths:
    M clang/tools/offload-arch/AMDGPUArchByKFD.cpp
    M clang/unittests/offload-arch/OffloadArchTest.cpp

  Log Message:
  -----------
  [offload-arch] Do not print "-strict" if it is disabled by the environment (#224688)

## Motivation

Right now, `HSA_DISABLE_GFX12_STRICT` is set to 1 by default, which the
runtime follows as "gfx1250". The only way to set the runtime to
"gfx1250-strict" is to set `HSA_DISABLE_GFX12_STRICT=0`. My
understanding is that this is a temporary patch to ROCr to ease the
transition to "gfx1250-strict". This PR adds a helper to reflect the
current state.

[This is how
ROCr](https://github.com/ROCm/rocm-systems/blob/28d10d31fcb04d53dedee5c6e66427f0b0449a9e/projects/rocr-runtime/runtime/hsa-runtime/core/util/flag.h#L256)
controls "strict". The very similar rocm_agent_enumerator code can be
found
[here](https://github.com/ROCm/rocm-systems/blob/855ab23c50ee8635e6c068fc3f9ec2eb01f075e0/projects/rocminfo/rocm_agent_enumerator#L270-L273).

## Testing

* Updated the unit tests to keep track of the environment variable and
to check for the expected value depending on it.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list