[all-commits] [llvm/llvm-project] 86f472: Reapply "[CFI] Create an external linkage alias in...

[Mircea Trofin via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 86f4728feefee41e53c1037b5918fb18e12a4696
      https://github.com/llvm/llvm-project/commit/86f4728feefee41e53c1037b5918fb18e12a4696
  Author: Mircea Trofin <mtrofin at google.com>
  Date:   2026-09-21 (Mon, 21 Sep 2026)

  Changed paths:
    M llvm/lib/Transforms/IPO/LowerTypeTests.cpp
    M llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp
    A llvm/test/ThinLTO/X86/cfi-import-internal-coroutine.ll
    A llvm/test/Transforms/LowerTypeTests/promoted-internal.ll
    M llvm/test/Transforms/ThinLTOBitcodeWriter/cfi-icall-static-inline-asm.ll
    A llvm/test/Transforms/ThinLTOBitcodeWriter/cfi_dso_local_equivalent.ll
    M llvm/test/Transforms/ThinLTOBitcodeWriter/comdat.ll
    M llvm/test/Transforms/ThinLTOBitcodeWriter/split-internal1.ll
    M llvm/test/Transforms/ThinLTOBitcodeWriter/split-internal2.ll
    M llvm/test/Transforms/ThinLTOBitcodeWriter/split-vfunc-internal.ll

  Log Message:
  -----------
  Reapply "[CFI] Create an external linkage alias instead of promoting i… (#220339) (#225173)

There were 3 issues with the original commit:

1. handling of `dso_local_equivalent`. This was subsequently addressed in PR #222036 as an independent fix. An earlier version of the fix, 220450, had an extra test, cfi_dso_local_equivalent.ll, which is specific to the interaction between this patch and dso_local_equivalent. That test is re-introduced here.
2. a COFF issue discovered through the original pass, uncovered on Chromium builds, and fixed by @andysjlim in PR #220674. Thank you!
3. an issue we discovered in google downstream, involving coroutines. See the `cfi-import-internal-coroutine.ll`, and the difference between the first version and the second version of this PR (in Graphite) (<- AI was used here)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications