[all-commits] [llvm/llvm-project] 4b99af: [MLIR][NFC] Drop sentinel leftovers from DenseMapI...

[Henrich Lauko via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4b99afb361a8cfd45fc17aebc637688661e9e472
      https://github.com/llvm/llvm-project/commit/4b99afb361a8cfd45fc17aebc637688661e9e472
  Author: Henrich Lauko <xlauko at mail.muni.cz>
  Date:   2026-09-21 (Mon, 21 Sep 2026)

  Changed paths:
    M mlir/include/mlir/IR/Remarks.h

  Log Message:
  -----------
  [MLIR][NFC] Drop sentinel leftovers from DenseMapInfo<Remark> (#224612)

`DenseMap` no longer uses sentinel keys, and the `getEmptyKey` and
`getTombstoneKey` members of `DenseMapInfo<Remark>` were removed in
#200633 and #201991. Two leftovers stayed behind, the `"<EMPTY_KEY>"`
comparison at the top of `isEqual` and the static dummy `MLIRContext`
that used to back the sentinel remarks.

The comparison is also wrong. A remark literally named `<EMPTY_KEY>`
compares unequal to any other remark, including one with a matching
hash, which breaks the hash and equality contract. This change removes
both leftovers and adds a comment saying what the specialization
compares, which is location, remark name, combined category name and
kind.

No behaviour change for any remark with a normal name. Existing Remark
unit tests and `mlir/test/Pass/remark-final.mlir` cover the
specialization through `RemarkEmittingPolicyFinal`.

Assisted-by: Claude Code (Claude Fable 5.1).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications