[all-commits] [llvm/llvm-project] cd5a0a: [libc] Move File::close out of line to file.cpp (#...

[Jeff Bailey via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cd5a0a4f07c92c65b23436d38b5aa8aa150f06dc
      https://github.com/llvm/llvm-project/commit/cd5a0a4f07c92c65b23436d38b5aa8aa150f06dc
  Author: Jeff Bailey <jbailey at raspberryginger.com>
  Date:   2026-09-20 (Sun, 20 Sep 2026)

  Changed paths:
    M libc/src/__support/File/file.cpp
    M libc/src/__support/File/file.h

  Log Message:
  -----------
  [libc] Move File::close out of line to file.cpp (#224901)

Moved File::close from src/__support/File/file.h into
src/__support/File/file.cpp and removed #include
"src/__support/CPP/new.h" from file.h, matching Dir::close in
src/__support/File/dir.h.

src/__support/CPP/new.h renames global operator delete via __asm__ to
__llvm_libc_delete (which calls free) for the entire translation unit
without renaming operator new. Including new.h in file.h leaked this
replacement operator delete into unit test translation units that
include file.h, causing an AddressSanitizer alloc-dealloc-mismatch in
Test::createCallable during death tests.

Assisted-by: Automated tooling, human reviewed.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications