[all-commits] [llvm/llvm-project] 8282b1: [LLDB] Convert multi-threaded test launches to lld...

[Adrian Prantl via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8282b18b2e998d215698c327184d87c63dc0c4e6
      https://github.com/llvm/llvm-project/commit/8282b18b2e998d215698c327184d87c63dc0c4e6
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2026-09-18 (Fri, 18 Sep 2026)

  Changed paths:
    M lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py
    M lldb/test/API/python_api/lldbutil/iter/TestRegistersIterator.py
    M lldb/test/API/python_api/watchpoint/watchlocation/TestSetWatchlocation.py
    M lldb/test/API/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py

  Log Message:
  -----------
  [LLDB] Convert multi-threaded test launches to lldbutil (NFC) (#224415)

Replace the CreateTarget + breakpoint + LaunchSimple + stop-assert
boilerplate with the matching lldbutil.run_to_*_breakpoint helper at 7
call sites.

Besides being shorter, the helpers check that the breakpoint resolved to
at least one location and that the process stopped at that specific
breakpoint, which most of the original code did not do.

It also improves and unifies the error reporting when the launch fails.

Note for reviewers: These inferiors are multi-threaded and the original
code used get_stopped_thread(), which tolerates several threads stopping
at once. The helpers require exactly one by default, so every call here
passes only_one_thread=False to preserve the previous behavior. Without
it TestLLDBIterator fails with "Expected 1 thread to stop at breakpoint,
3 did" - but only under load, which makes this easy to miss when running
a single test.

Assisted-by: Claude



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications