[all-commits] [llvm/llvm-project] af59e6: [AMDGPU] Remove `hasSideEffects` from `SI_IF`, `SI...

Igor Wodiany via All-commits all-commits at lists.llvm.org
Fri Sep 18 01:42:48 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: af59e6e8eef55e3651dee022bd0874a695637bb2
      https://github.com/llvm/llvm-project/commit/af59e6e8eef55e3651dee022bd0874a695637bb2
  Author: Igor Wodiany <igor.wodiany at amd.com>
  Date:   2026-09-18 (Fri, 18 Sep 2026)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIInstructions.td

  Log Message:
  -----------
  [AMDGPU] Remove `hasSideEffects` from `SI_IF`, `SI_ELSE` and `SI_LOOP` (#224007)

An arbitrary side-effect flag blocks sinking of memory operations due to
the unmodelled-side-effect check returning true. This change has no
effect on other transformations as modeled side effects (EXEC and SCC
defs) are still accounted for and sufficient to gate unsound code
motion. All three instructions are still rejected by `isSafeToMove` as
they carry the terminator flag.

This commit is part of the effort to enhance `MachineSink` on the AMDGPU
target. By itself itself it does not unblock more code motion
opportunities but it is a prerequisite to do so.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list