[all-commits] [llvm/llvm-project] 327153: [lldb][cmake] Accept config-mode packages in add_o...

[Charles Zablit via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 327153dcd71bbec2fa827b84fa513c7c6cf88ce0
      https://github.com/llvm/llvm-project/commit/327153dcd71bbec2fa827b84fa513c7c6cf88ce0
  Author: Charles Zablit <c_zablit at apple.com>
  Date:   2026-09-16 (Wed, 16 Sep 2026)

  Changed paths:
    M lldb/cmake/modules/FindCursesAndPanel.cmake
    M lldb/cmake/modules/FindLuaAndSwig.cmake
    M lldb/cmake/modules/FindPythonAndSwig.cmake
    M lldb/cmake/modules/LLDBConfig.cmake

  Log Message:
  -----------
  [lldb][cmake] Accept config-mode packages in add_optional_dependency (#222976)

`add_optional_dependency` copies the caller-supplied `<found>` variable
after `find_package`, and callers name the Find module's result
variable, which is usually all-caps (`LIBXML2_FOUND`, `CURSES_FOUND`). A
package located in config mode only sets `<PackageName>_FOUND`
(`LibXml2_FOUND`), so the copy comes back empty and the dependency is
reported as missing and silently disabled even though `find_package`
succeeded.

Set the result variable to TRUE when either `${found}` or
`${package}_FOUND` is set, FALSE otherwise.

Behavior for module-mode finds is unchanged; only the config-mode case,
which previously always evaluated to false, is affected.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications