[all-commits] [llvm/llvm-project] 5212f7: AMDGPU: Use LiveIntervals in SIOptimizeVGPRLiveRan...

[Matt Arsenault via All-commits]

  Branch: refs/heads/users/arsenm/amdgpu/siopt-vgpr-liverange-lis
  Home:   https://github.com/llvm/llvm-project
  Commit: 5212f73eae92f3a6de1a37b333bb0dff9a570ca5
      https://github.com/llvm/llvm-project/commit/5212f73eae92f3a6de1a37b333bb0dff9a570ca5
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2026-09-15 (Tue, 15 Sep 2026)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp
    M llvm/test/CodeGen/AMDGPU/opt-vgpr-live-range-verifier-error.mir
    M llvm/test/CodeGen/AMDGPU/si-opt-vgpr-liverange-bug-deadlanes.mir

  Log Message:
  -----------
  AMDGPU: Use LiveIntervals in SIOptimizeVGPRLiveRange when available

LiveVariables has been long deprecated. Use LiveIntervals if available.
With the current pass structure, this will use LiveVariables.

Co-authored-by: Claude (Claude-Opus-4.8)


  Commit: d279803e62af449099491b63227d378f0368722d
      https://github.com/llvm/llvm-project/commit/d279803e62af449099491b63227d378f0368722d
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2026-09-15 (Tue, 15 Sep 2026)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp

  Log Message:
  -----------
  Address review comments


  Commit: 3a5cbc7ea10ddbec49d2e75ae4c982ec4107a85d
      https://github.com/llvm/llvm-project/commit/3a5cbc7ea10ddbec49d2e75ae4c982ec4107a85d
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2026-09-15 (Tue, 15 Sep 2026)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp

  Log Message:
  -----------
  Preserve LiveVariables in the new PM only when it was used


  Commit: 79718a518de132f6d1b9fd90f21de2b0fca12470
      https://github.com/llvm/llvm-project/commit/79718a518de132f6d1b9fd90f21de2b0fca12470
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2026-09-15 (Tue, 15 Sep 2026)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp

  Log Message:
  -----------
  Restore addPreserved<LiveVariables> to keep the pass NFC

In the current pipeline LiveIntervals runs after SIOptimizeVGPRLiveRange, so
LIS is null here and the LiveVariables path runs unchanged. Dropping the
addPreserved<LiveVariablesWrapperPass> made LiveVariables recompute before
PHIElimination instead of reusing the analysis this pass maintains, changing
downstream kill/edge-split decisions and producing observable codegen diffs.
Preserve it again so the pass stays NFC until the pipeline is flipped to run
LiveIntervals first.

Co-Authored-By: Claude claude-opus-4.8 <noreply at anthropic.com>


  Commit: df1679f542d3b9f4eaa1e0fa420b81109b6b991e
      https://github.com/llvm/llvm-project/commit/df1679f542d3b9f4eaa1e0fa420b81109b6b991e
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2026-09-15 (Tue, 15 Sep 2026)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIOptimizeVGPRLiveRange.cpp

  Log Message:
  -----------
  Maintain LiveIntervals and LiveVariables independently


Compare: https://github.com/llvm/llvm-project/compare/3e873afb46f5...df1679f542d3

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications