[all-commits] [llvm/llvm-project] 0f0d6b: [bazel][libc] Be explicit about pic/nopic in start...
Jackson Stogel via All-commits
all-commits at lists.llvm.org
Tue Sep 15 14:24:52 PDT 2026
Branch: refs/heads/users/jtstogel/full-build/startup-rules
Home: https://github.com/llvm/llvm-project
Commit: 0f0d6b4be2b7a512ea23d5d56ba266b41d74473f
https://github.com/llvm/llvm-project/commit/0f0d6b4be2b7a512ea23d5d56ba266b41d74473f
Author: jtstogel <jtstogel at gmail.com>
Date: 2026-09-15 (Tue, 15 Sep 2026)
Changed paths:
M utils/bazel/llvm-project-overlay/libc/startup/linux/BUILD.bazel
M utils/bazel/llvm-project-overlay/libc/startup/linux/startup_rules.bzl
Log Message:
-----------
[bazel][libc] Be explicit about pic/nopic in startup_rules.bzl
Currently, this implementation gets object files from `OuputGroupInfo.compilation_outputs`, which isn't very well documented any will often just choose the PIC variant: [`cc_helper.bzl`](https://github.com/bazelbuild/rules_cc/blob/661b75de668c3b673f5550e0340e134ccf923956/cc/common/cc_helper.bzl#L192).
This PR updates `merge_relocatable_object` to propagate both pic/nopic variants of the merged object, and updates `libc_startup_object` to be explicit about its choice of pic/nopic.
The exact choice of how to handle pic/nopic may need to be updated in the future, but the changes in this PR is better than just using compilation_outputs verbatim.
To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications
More information about the All-commits
mailing list