[all-commits] [llvm/llvm-project] b16a0c: [mlir][ROCDL] Add `rocdl.xnack` and `rocdl.sramecc...

[Krzysztof Drewniak via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b16a0c1d3488ddc7d0e406288aae2e363a8af537
      https://github.com/llvm/llvm-project/commit/b16a0c1d3488ddc7d0e406288aae2e363a8af537
  Author: Krzysztof Drewniak <Krzysztof.Drewniak at amd.com>
  Date:   2026-09-14 (Mon, 14 Sep 2026)

  Changed paths:
    M mlir/include/mlir/Dialect/LLVMIR/ROCDLDialect.td
    M mlir/lib/Dialect/LLVMIR/IR/ROCDLDialect.cpp
    M mlir/lib/Target/LLVMIR/Dialect/ROCDL/ROCDLToLLVMIRTranslation.cpp
    M mlir/test/Dialect/LLVMIR/rocdl.mlir
    M mlir/test/Target/LLVMIR/rocdl-module-flags.mlir

  Log Message:
  -----------
  [mlir][ROCDL] Add `rocdl.xnack` and `rocdl.sramecc` module attributes (#222444)

Since 27eeb7370281, the AMDGPU backend takes the xnack
and sramecc target-ID settings from the `amdgpu.xnack` and
`amdgpu.sramecc` module flags instead subtarget features, making the
old usage a hard error.

This commit adds `rocdl.xnack` and `rocdl.sramecc` module attributes
to the discardable attribute list the ROCDL dialect defines in order
to represent these flags and adds translations for them.

Omitting them means to leave these modifiers at
their default "either" state, which isn't the same as setting them to
false.

AI disclosure: Claude wrote this code and I reviewed it and tried to
reword the comments to something better.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications