[all-commits] [llvm/llvm-project] 41c11f: [libc++][test] Remove non-functional `constexpr` i...

[A. Jiang via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 41c11fa5c016886d5858a1aba03a5980688ad5a1
      https://github.com/llvm/llvm-project/commit/41c11fa5c016886d5858a1aba03a5980688ad5a1
  Author: A. Jiang <de34 at live.cn>
  Date:   2026-09-11 (Fri, 11 Sep 2026)

  Changed paths:
    M libcxx/test/std/utilities/variant/variant.relops/three_way.pass.cpp

  Log Message:
  -----------
  [libc++][test] Remove non-functional `constexpr` in three-way comparison test for `variant` (#222837)

When we are just testing SFINAE and do not provide definitions for these
comparison operators, or make them deleted, it is unhelpful to mark them
`constexpr`.

If the implementation uses `std::compare_three_way`, which uses deduced
return type in its `operator()`, in the `operator<=>` for `variant`,
more things in the function body would be instantiated and detected. As
a result, the `-Wundefined-inline` warning or something similar could be
raised. Currently, MSVC STL is doing so.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications