[all-commits] [llvm/llvm-project] 19dad0: [lldb] Fix handling of lldb managed software break...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 19dad062e98520c641617fda2cec07592764d5dc
      https://github.com/llvm/llvm-project/commit/19dad062e98520c641617fda2cec07592764d5dc
  Author: David Spickett <david.spickett at arm.com>
  Date:   2026-09-11 (Fri, 11 Sep 2026)

  Changed paths:
    M lldb/include/lldb/Breakpoint/StopPointSiteList.h
    M lldb/test/API/functionalities/breakpoint/write_over_software_breakpoint/TestWriteOverSoftwareBreakpoint.py

  Log Message:
  -----------
  [lldb] Fix handling of lldb managed software breakpoints (#222009)

Fixes #217910.

When the debug server can manage its own breakpoints this is called an
"external" breakpoint. When it cannot, lldb must manage the breakpoint
itself from the client side.

Part of doing that is FindInRange which is used to patch reads and
writes over software breakpoint sites. It had an issue where it would
not account for a breakpoint that started before the range, but extended
into the range. For example:
```
      Memory content: ABCDEFGHIJKL
          Read range: ----[--]----
 Breakpoint location: -BKPT-------
   Overlap with read: ---- at -------
Expected read result: ----EFGH----
  Would actually get: ----TFGH----
```
This change fixes that mistake:
* Exit early if there are no sites to check.
* Exit early if the lower_bound result is beyond the upper bound of the
range - only if the result is not the end of the list. In the result was
end(), there may be one site before which we must also check.

The existing "Over end of breakpoint" test covers the bug I'm fixing.
The tests have been refactored to run normally and via. a proxy that
refuses breakpoint packets.

We could instead use two different proxies where one supports the
packets and one doesn't. However, that's more overhead per test and you
can't run proxy tests remotely.

Due to https://github.com/llvm/llvm-project/issues/222284, the proxy
tests cannot be run everywhere, but it can run on AArch64 which is
common.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications