[all-commits] [llvm/llvm-project] 26c633: [lldb] Move most PDB shell tests to NativePDB (#22...

[Nerixyz via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 26c633bf88337258f1b488bccfd74faa1efbafaa
      https://github.com/llvm/llvm-project/commit/26c633bf88337258f1b488bccfd74faa1efbafaa
  Author: Nerixyz <nerixdev at outlook.de>
  Date:   2026-09-10 (Thu, 10 Sep 2026)

  Changed paths:
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/AstRestoreTest.cpp
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/CallingConventionsTest.cpp
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/ClassLayoutTest.cpp
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/CompilandsTest.cpp
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/ExpressionsTest.cpp
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/ExpressionsTest0.script
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/ExpressionsTest1.script
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/ExpressionsTest2.script
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/FunctionLevelLinkingTest.cpp
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/FunctionLevelLinkingTest.h
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/FunctionLevelLinkingTest.ord
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/FunctionNestedBlockTest.cpp
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/PointerTypeTest.cpp
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/SimpleTypesTest.cpp
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/TypeQualsTest.cpp
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/VBases2.cpp
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/VBases2.script
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/VariablesLocationsTest.cpp
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/VariablesLocationsTest.script
    A lldb/test/Shell/SymbolFile/NativePDB/Inputs/VariablesTest.cpp
    A lldb/test/Shell/SymbolFile/NativePDB/add-symbols.cpp
    A lldb/test/Shell/SymbolFile/NativePDB/ast-restore.test
    A lldb/test/Shell/SymbolFile/NativePDB/calling-conventions-arm.test
    A lldb/test/Shell/SymbolFile/NativePDB/calling-conventions-x86.test
    A lldb/test/Shell/SymbolFile/NativePDB/class-layout.test
    A lldb/test/Shell/SymbolFile/NativePDB/compilands.test
    A lldb/test/Shell/SymbolFile/NativePDB/enums-layout.test
    A lldb/test/Shell/SymbolFile/NativePDB/expressions.test
    M lldb/test/Shell/SymbolFile/NativePDB/func-symbols.test
    A lldb/test/Shell/SymbolFile/NativePDB/function-level-linking.test
    A lldb/test/Shell/SymbolFile/NativePDB/function-nested-block.test
    A lldb/test/Shell/SymbolFile/NativePDB/native-setting-dia.cpp
    A lldb/test/Shell/SymbolFile/NativePDB/native-setting-no-dia.cpp
    R lldb/test/Shell/SymbolFile/NativePDB/native-setting.cpp
    A lldb/test/Shell/SymbolFile/NativePDB/pointers.test
    A lldb/test/Shell/SymbolFile/NativePDB/type-quals.test
    A lldb/test/Shell/SymbolFile/NativePDB/typedefs.test
    A lldb/test/Shell/SymbolFile/NativePDB/variables-locations.test
    A lldb/test/Shell/SymbolFile/NativePDB/variables.test
    A lldb/test/Shell/SymbolFile/NativePDB/vbases2.test
    R lldb/test/Shell/SymbolFile/PDB/Inputs/AstRestoreTest.cpp
    R lldb/test/Shell/SymbolFile/PDB/Inputs/CallingConventionsTest.cpp
    R lldb/test/Shell/SymbolFile/PDB/Inputs/ClassLayoutTest.cpp
    R lldb/test/Shell/SymbolFile/PDB/Inputs/CompilandsTest.cpp
    R lldb/test/Shell/SymbolFile/PDB/Inputs/ExpressionsTest.cpp
    R lldb/test/Shell/SymbolFile/PDB/Inputs/ExpressionsTest0.script
    R lldb/test/Shell/SymbolFile/PDB/Inputs/ExpressionsTest1.script
    R lldb/test/Shell/SymbolFile/PDB/Inputs/ExpressionsTest2.script
    R lldb/test/Shell/SymbolFile/PDB/Inputs/FunctionLevelLinkingTest.cpp
    R lldb/test/Shell/SymbolFile/PDB/Inputs/FunctionLevelLinkingTest.h
    R lldb/test/Shell/SymbolFile/PDB/Inputs/FunctionLevelLinkingTest.ord
    R lldb/test/Shell/SymbolFile/PDB/Inputs/FunctionNestedBlockTest.cpp
    R lldb/test/Shell/SymbolFile/PDB/Inputs/PointerTypeTest.cpp
    R lldb/test/Shell/SymbolFile/PDB/Inputs/SimpleTypesTest.cpp
    R lldb/test/Shell/SymbolFile/PDB/Inputs/TypeQualsTest.cpp
    R lldb/test/Shell/SymbolFile/PDB/Inputs/VBases.cpp
    R lldb/test/Shell/SymbolFile/PDB/Inputs/VBases.script
    R lldb/test/Shell/SymbolFile/PDB/Inputs/VariablesLocationsTest.cpp
    R lldb/test/Shell/SymbolFile/PDB/Inputs/VariablesLocationsTest.script
    R lldb/test/Shell/SymbolFile/PDB/Inputs/VariablesTest.cpp
    R lldb/test/Shell/SymbolFile/PDB/add-symbols.cpp
    R lldb/test/Shell/SymbolFile/PDB/ast-restore.test
    R lldb/test/Shell/SymbolFile/PDB/calling-conventions-arm.test
    R lldb/test/Shell/SymbolFile/PDB/calling-conventions-x86.test
    R lldb/test/Shell/SymbolFile/PDB/class-layout.test
    R lldb/test/Shell/SymbolFile/PDB/compilands.test
    R lldb/test/Shell/SymbolFile/PDB/enums-layout.test
    R lldb/test/Shell/SymbolFile/PDB/expressions.test
    M lldb/test/Shell/SymbolFile/PDB/func-symbols.test
    R lldb/test/Shell/SymbolFile/PDB/function-level-linking.test
    R lldb/test/Shell/SymbolFile/PDB/function-nested-block.test
    R lldb/test/Shell/SymbolFile/PDB/native-setting.cpp
    R lldb/test/Shell/SymbolFile/PDB/pointers.test
    R lldb/test/Shell/SymbolFile/PDB/type-quals.test
    R lldb/test/Shell/SymbolFile/PDB/typedefs.test
    M lldb/test/Shell/SymbolFile/PDB/udt-layout.test
    R lldb/test/Shell/SymbolFile/PDB/variables-locations.test
    R lldb/test/Shell/SymbolFile/PDB/variables.test
    R lldb/test/Shell/SymbolFile/PDB/vbases.test

  Log Message:
  -----------
  [lldb] Move most PDB shell tests to NativePDB (#222370)

I plan to remove the DIA PDB plugin before the 24 release - we switched
the default to the native one in 22. To avoid losing test coverage in
the process, this moves the SymbolFile/PDB tests to
SymbolFile/NativePDB. They were already running with both plugins. In
some cases, we set `env LLDB_USE_NATIVE_PDB_READER=1`, which I flipped.

The remaining shell tests are:
- `func-symbols.test`: Has a duplicate in NativePDB with different
checks, because the two plugins don't create identical types (see
comment in test)
- `udt-layout.test`: Also has a duplicate with different checks, because
the two plugins show the base classes in a different order.

Other than that, there's also a [unittest for
PDB](https://github.com/llvm/llvm-project/blob/2de38b4861ed4a7be7ddd42fc803e91d1fe81b14/lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp).
I'm not sure what we should do about it. Looking over the tests there,
most of these are already covered by the shell tests.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications