[all-commits] [llvm/llvm-project] 2c4c9d: [SPIRV] Fix inconsistent operand order for counter...

Helena Kotas via All-commits all-commits at lists.llvm.org
Wed Sep 9 17:48:27 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2c4c9d84bd948a92bb78b46a1c34044e246fd187
      https://github.com/llvm/llvm-project/commit/2c4c9d84bd948a92bb78b46a1c34044e246fd187
  Author: Helena Kotas <hekotas at microsoft.com>
  Date:   2026-09-09 (Wed, 09 Sep 2026)

  Changed paths:
    M llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
    M llvm/lib/Target/SPIRV/SPIRVLegalizeImplicitBinding.cpp
    M llvm/test/CodeGen/SPIRV/hlsl-resources/ImplicitBinding.ll

  Log Message:
  -----------
  [SPIRV] Fix inconsistent operand order for counter resource intrinsic (#221646)

The `llvm.spv.resource.handlefrombinding` intrinsic stores its binding
operands in the order (DescriptorSet, BindingNo, ...). The
`llvm.spv.resource.counterhandlefrombinding` intrinsic should use the
same order.

The `llvm.spv.resource.counterhandlefrombinding` intrinsic is currently
emitted only by the `SPIRVLegalizeImplicitBinding` pass. The pass
previously built its operands in the wrong order, and the instruction
selector repeated the same inversion when emitting decorations.

This change makes the operand order consistent with
`llvm.spv.resource.handlefrombinding`.

Test update closes a coverage gap - there were no tests for explicit
`llvm.spv.resource.counterhandlefrombinding` calls.

Assisted by GPT-5.6 Sol.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list