[all-commits] [llvm/llvm-project] 3ff772: Fix extension matching and reachable path merging

Chi-Chun, Chen via All-commits all-commits at lists.llvm.org
Tue Sep 8 11:58:07 PDT 2026


  Branch: refs/heads/users/cchen/flang-metadirective-loop-reachable-paths
  Home:   https://github.com/llvm/llvm-project
  Commit: 3ff772bbd6614ab3ef3bf73966ed6899711c0e81
      https://github.com/llvm/llvm-project/commit/3ff772bbd6614ab3ef3bf73966ed6899711c0e81
  Author: Chi-Chun, Chen <chichun.chen at hpe.com>
  Date:   2026-09-08 (Tue, 08 Sep 2026)

  Changed paths:
    M flang/lib/Semantics/check-omp-variant.cpp
    M flang/test/Semantics/OpenMP/metadirective-loop-applicability.f90
    A flang/test/Semantics/OpenMP/metadirective-match-any-paths.f90
    A flang/test/Semantics/OpenMP/metadirective-ordered-paths.f90
    M llvm/lib/Frontend/OpenMP/OMPContext.cpp
    M llvm/unittests/Frontend/OpenMPContextTest.cpp

  Log Message:
  -----------
  Fix extension matching and reachable path merging

Metadirective semantic checking relies on ranked selection to decide which
replacements need validation. With match_any and match_none, a selector can
remain applicable even when some construct traits are absent. The existing
matching and path-merging assumptions do not fully account for this, so
ranking can crash or discard a reachable replacement, allowing invalid loop
nests to pass unchecked.

Make applicability, scoring, and reachable-path merging agree on what these
matching extensions can observe. Preserve enough construct context to rank
partially matching selectors and distinguish paths whose nesting changes
the selected replacement. That context must also remain visible inside a
BLOCK associated with a selected directive, so nested metadirectives are
checked against the context in which they can execute.


  Commit: 31cb39e841cc92509c0ffd9cfcfddf7cf9e28cae
      https://github.com/llvm/llvm-project/commit/31cb39e841cc92509c0ffd9cfcfddf7cf9e28cae
  Author: Chi-Chun, Chen <chichun.chen at hpe.com>
  Date:   2026-09-08 (Tue, 08 Sep 2026)

  Changed paths:
    M flang/lib/Semantics/check-omp-structure.h
    M flang/lib/Semantics/check-omp-variant.cpp
    M flang/test/Semantics/OpenMP/metadirective-loop-applicability.f90
    M llvm/lib/Frontend/OpenMP/OMPContext.cpp

  Log Message:
  -----------
  Remove redundant handling, improve style, and add documentation


Compare: https://github.com/llvm/llvm-project/compare/6f3b7881ac36...31cb39e841cc

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list