[all-commits] [llvm/llvm-project] 5886c7: [clang] Unique more ASTContext type pools in a Uni...

Fangrui Song via All-commits all-commits at lists.llvm.org
Tue Sep 8 01:39:31 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5886c703eb2d205656811d78db82b76524c47da9
      https://github.com/llvm/llvm-project/commit/5886c703eb2d205656811d78db82b76524c47da9
  Author: Fangrui Song <i at maskray.me>
  Date:   2026-09-08 (Tue, 08 Sep 2026)

  Changed paths:
    M clang/include/clang/AST/ASTContext.h
    M clang/include/clang/AST/TypeBase.h
    M clang/lib/AST/ASTContext.cpp
    M clang/lib/AST/StmtProfile.cpp
    M clang/lib/AST/Type.cpp

  Log Message:
  -----------
  [clang] Unique more ASTContext type pools in a UniquingSet. NFC (#221898)

Similar to #221850.

Eight pools key on a small tuple of types, integers and pointers, yet
each get*Type() serializes that into a FoldingSetNodeID and hashes it
out of line before probing. Switch to UniquingSet.

These getters re-probe after building the canonical type. A token is a
hash (#218190), not a bucket, so nothing invalidates it. Drop unneeded
assertions.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list