[all-commits] [llvm/llvm-project] 6a183b: [ADT] Document the UniquingSet contracts. NFC (#22...

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6a183b8853b79a134402332cf4a776a8090d1b88
      https://github.com/llvm/llvm-project/commit/6a183b8853b79a134402332cf4a776a8090d1b88
  Author: Fangrui Song <i at maskray.me>
  Date:   2026-09-08 (Tue, 08 Sep 2026)

  Changed paths:
    M llvm/docs/ProgrammersManual.md
    M llvm/unittests/ADT/FoldingSet.cpp

  Log Message:
  -----------
  [ADT] Document the UniquingSet contracts. NFC (#221860)

#220195 added an isEqual hook, so an Info can now override the
comparison as well as the key and the hash. Name the three hooks, and
correct the guidance on when to prefer UniquingSet over FoldingSet.

Cover getOrInsert, which UniquingSet had no test for: an absent key
inserts, an equal key returns the node already in the set.

Aided by Opus 5

Co-authored-by: Kazu Hirata <kazu at google.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications