[all-commits] [llvm/llvm-project] 7efd21: [clang] Unique the QualType-keyed type pools in a ...

Fangrui Song via All-commits all-commits at lists.llvm.org
Mon Sep 7 20:24:56 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7efd21ff7aceefcec79adced0dcc99bf121e9696
      https://github.com/llvm/llvm-project/commit/7efd21ff7aceefcec79adced0dcc99bf121e9696
  Author: Fangrui Song <i at maskray.me>
  Date:   2026-09-07 (Mon, 07 Sep 2026)

  Changed paths:
    M clang/include/clang/AST/ASTContext.h
    M clang/include/clang/AST/TypeBase.h
    M clang/lib/AST/ASTContext.cpp

  Log Message:
  -----------
  [clang] Unique the QualType-keyed type pools in a UniquingSet. NFC (#221850)

Eight of the ASTContext type pools key on a QualType, or on a QualType
and a bool. The `get*Type()` functions incur the FoldingSetNodeID
serialization overhead before probing the hash table.

Switch to UniquingSet. Define `QualTypeBoolInfo` for three pools that
key on a QualType and a bool, because DenseMapInfo has no bool
specialization.

After the canonical type is built, these getters re-probe to refresh the
insert token. A token is now a hash (#218190), not a bucket, so nothing
invalidates it; fold the re-probe into the assertion it feeds.

Aided by Opus 5



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list