[all-commits] [llvm/llvm-project] 3779bc: [libc++] Switch the enable_warnings Lit parameter ...

[Louis Dionne via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3779bcb1b7bd9d7d82ee43b232e1a98c14e1b104
      https://github.com/llvm/llvm-project/commit/3779bcb1b7bd9d7d82ee43b232e1a98c14e1b104
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2026-08-07 (Fri, 07 Aug 2026)

  Changed paths:
    M libcxx/test/libcxx/diagnostics/unused_variables.verify.cpp
    R libcxx/test/selftest/pass.cpp/werror.pass.cpp
    R libcxx/test/selftest/sh.cpp/werror.sh.cpp
    M libcxx/utils/libcxx/test/params.py

  Log Message:
  -----------
  [libc++] Switch the enable_warnings Lit parameter to enable_werror (#214113)

Our enable_warnings=False parameter in the test suite was basically not
working as intended. Instead of disabling warnings, it would disable all
warning-related flags, including flags that are required for the test
suite to pass (e.g. -Wno-user-defined-literals). As a result, it
couldn't be turned off.

Remove enable_warnings and introduce enable_werror instead. That way, we
can disable -Werror in the test suite but the warnings (and -Wno-foo)
are always used, which is necessary for the test suite to function.

Note that the ability to run the test suite without -Werror is necessary
in order to test against other implementations, including older versions
of libc++ itself.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications