[all-commits] [llvm/llvm-project] 429b2a: [SYCL][SPIR-V][Windows] Extend BaseSPIRTargetInfo ...

schittir via All-commits all-commits at lists.llvm.org
Thu Aug 6 12:31:53 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 429b2a7b3317384313000094f32e2dda7803f4fb
      https://github.com/llvm/llvm-project/commit/429b2a7b3317384313000094f32e2dda7803f4fb
  Author: schittir <sindhu.chittireddy at intel.com>
  Date:   2026-08-06 (Thu, 06 Aug 2026)

  Changed paths:
    M clang/lib/Basic/Targets/SPIR.h
    M clang/lib/Driver/ToolChains/SYCL.cpp
    M clang/lib/Driver/ToolChains/SYCL.h
    A clang/test/CodeGenSPIRV/spirv-host-adaptation-valist.cpp
    A clang/test/Driver/sycl-msvc-version-propagation.cpp
    A clang/test/Preprocessor/spir-host-adaptation-macros.cpp
    A clang/test/Preprocessor/spirv-host-adaptation-macros.cpp
    A clang/test/SemaSPIRV/spirv-host-adaptation-types.cpp
    A clang/test/SemaSPIRV/spirv-host-adaptation-valist.cpp

  Log Message:
  -----------
  [SYCL][SPIR-V][Windows] Extend BaseSPIRTargetInfo host-adaptation for Windows support (#208196)

The existing host-adaptation mechanism in BaseSPIRTargetInfo copies type
properties from the host but has gaps causing incorrect behavior on
Windows:

1. PointerWidth/PointerAlign, SizeType, PtrDiffType, IntPtrType were not
  copied from the host; derived classes hardcoded LP64 defaults.
  2. getBuiltinVaListKind() returned VoidPtr unconditionally instead of
  delegating to the host's va_list kind.
  3. Derived-class constructors unconditionally overwrote host-adapted
  values, working on Linux only by coincidence.

  This patch addresses these issues by copying pointer-related types
from the host in BaseSPIRTargetInfo, delegating va_list kind to the
host,
and setting architecture-appropriate defaults in derived classes when no
host is
  present or when host and device pointer widths differ.

  TO-DO (follow-up PR): 
  Diagnose invalid host-target pairings.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list