[all-commits] [llvm/llvm-project] 849c51: [compiler-rt] Disable executable stack on `aeabi_u...

[Trevor Gross via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 849c51e082b0958524246a0a880f46d468a55147
      https://github.com/llvm/llvm-project/commit/849c51e082b0958524246a0a880f46d468a55147
  Author: Trevor Gross <tg at trevorgross.com>
  Date:   2026-08-06 (Thu, 06 Aug 2026)

  Changed paths:
    M compiler-rt/lib/builtins/arm/aeabi_uread4.S
    M compiler-rt/lib/builtins/arm/aeabi_uread8.S
    M compiler-rt/lib/builtins/arm/aeabi_uwrite4.S
    M compiler-rt/lib/builtins/arm/aeabi_uwrite8.S

  Log Message:
  -----------
  [compiler-rt] Disable executable stack on `aeabi_u{read,write}*.S` (#214465)

These were missing `NO_EXEC_STACK_DIRECTIVE` to add `.note.GNU-stack`;
without it, a binary including any of these files will have the stack
marked executable. Add the directive here, matching other similar files.

Symtab diff before:

$ clang compiler-rt/lib/builtins/arm/aeabi_uread4.S
--target=arm-unknown-linux-gnueabi -c
    $ llvm-readelf aeabi_uread4.o -S
    There are 5 section headers, starting at offset 0xe4:

    Section Headers:
[Nr] Name Type Address Off Size ES Flg Lk Inf Al
[ 0] NULL 00000000 000000 000000 00 0 0 0
[ 1] .strtab STRTAB 00000000 0000a8 000039 00 0 0 1
[ 2] .text PROGBITS 00000000 000034 000020 00 AX 0 0 4
[ 3] .ARM.attributes ARM_ATTRIBUTES 00000000 000054 000022 00 0 0 1
[ 4] .symtab SYMTAB 00000000 000078 000030 10 1 2 4

After:

$ clang compiler-rt/lib/builtins/arm/aeabi_uread4.S
--target=arm-unknown-linux-gnueabi -c
    $ llvm-readelf aeabi_uread4.o -S
    There are 6 section headers, starting at offset 0xf4:

    Section Headers:
[Nr] Name Type Address Off Size ES Flg Lk Inf Al
[ 0] NULL 00000000 000000 000000 00 0 0 0
[ 1] .strtab STRTAB 00000000 0000a8 000049 00 0 0 1
[ 2] .text PROGBITS 00000000 000034 000020 00 AX 0 0 4
[ 3] .note.GNU-stack PROGBITS 00000000 000054 000000 00 0 0 1
[ 4] .ARM.attributes ARM_ATTRIBUTES 00000000 000054 000022 00 0 0 1
[ 5] .symtab SYMTAB 00000000 000078 000030 10 1 2 4

Fixes: 39413af931a7 ("[Compiler-rt] Implement AEABI Unaligned Read/Write
       Helpers in compiler-rt (#167913)")



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications