[all-commits] [llvm/llvm-project] b56b50: [HLSL] Consistently quote resource attribute args ...

[Justin Bogner via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b56b5068c5baa7c8528bb9a111fd14b87d6a458c
      https://github.com/llvm/llvm-project/commit/b56b5068c5baa7c8528bb9a111fd14b87d6a458c
  Author: Justin Bogner <mail at justinbogner.com>
  Date:   2026-08-05 (Wed, 05 Aug 2026)

  Changed paths:
    M clang/lib/AST/TypePrinter.cpp
    M clang/lib/Sema/SemaHLSL.cpp
    M clang/test/AST/HLSL/ByteAddressBuffers-AST.hlsl
    M clang/test/AST/HLSL/ConstantBuffers-AST.hlsl
    M clang/test/AST/HLSL/StructuredBuffers-AST.hlsl
    M clang/test/AST/HLSL/Textures-AST.hlsl
    M clang/test/AST/HLSL/Textures-scalar-AST.hlsl
    M clang/test/AST/HLSL/Textures-vector-AST.hlsl
    M clang/test/AST/HLSL/TypedBuffers-AST.hlsl
    M clang/test/CodeGenHLSL/BasicFeatures/InitLists.hlsl
    M clang/test/CodeGenHLSL/builtins/hlsl_resource_t.hlsl
    M clang/test/ParserHLSL/hlsl_contained_type_attr.hlsl
    M clang/test/ParserHLSL/hlsl_is_array_attr.hlsl
    M clang/test/ParserHLSL/hlsl_is_ms_attr.hlsl
    M clang/test/ParserHLSL/hlsl_is_rov_attr.hlsl
    M clang/test/ParserHLSL/hlsl_raw_buffer_attr.hlsl
    M clang/test/ParserHLSL/hlsl_resource_class_attr.hlsl
    M clang/test/ParserHLSL/hlsl_resource_dimension_attr.hlsl
    M clang/test/ParserHLSL/hlsl_resource_handle_attrs.hlsl
    M clang/test/SemaHLSL/Attributes/hlsl_contained_type_attr_error.hlsl
    M clang/test/SemaHLSL/Attributes/hlsl_is_array_attr_error.hlsl
    M clang/test/SemaHLSL/Attributes/hlsl_is_ms_attr_error.hlsl
    M clang/test/SemaHLSL/Attributes/hlsl_is_rov_attr_error.hlsl
    M clang/test/SemaHLSL/Attributes/hlsl_raw_buffer_attr_error.hlsl
    M clang/test/SemaHLSL/Attributes/hlsl_resource_class_attr_error.hlsl
    M clang/test/SemaHLSL/BuiltIns/buffer_update_counter-errors.hlsl
    M clang/test/SemaHLSL/BuiltIns/resource_getpointer-errors.hlsl
    M clang/test/SemaHLSL/Resources/resource_binding_attr_error.hlsl
    M clang/test/SemaHLSL/Resources/resource_binding_attr_error_resource.hlsl
    M clang/test/SemaHLSL/Resources/resource_binding_attr_error_udt.hlsl
    M clang/test/SemaHLSL/Resources/resource_binding_attr_error_uint32_max.hlsl
    M clang/test/SemaHLSL/Resources/resource_binding_implicit.hlsl

  Log Message:
  -----------
  [HLSL] Consistently quote resource attribute args (#214106)

The `hlsl::resource_class` and `hlsl::dimension` attributes both take a
single argument from a set of choices, but resource_class expects an
unevaluated identifier and dimension expects a string literal.
Consistently require the literal for both, and fix up the AST printers
to match.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications