[all-commits] [llvm/llvm-project] e96646: [OpenMP][NFC] Refresh stale entry-layout comments ...

Abhinav Gaba via All-commits all-commits at lists.llvm.org
Tue Aug 4 12:06:15 PDT 2026


  Branch: refs/heads/users/abhinavgaba/attach-maps-in-mappers-4
  Home:   https://github.com/llvm/llvm-project
  Commit: e96646304dd8c81ec086194b429e17dae28ba46e
      https://github.com/llvm/llvm-project/commit/e96646304dd8c81ec086194b429e17dae28ba46e
  Author: Abhinav Gaba <abhinav.gaba at intel.com>
  Date:   2026-08-04 (Tue, 04 Aug 2026)

  Changed paths:
    M clang/test/OpenMP/target_map_nested_ptr_member_mapper_codegen.cpp

  Log Message:
  -----------
  [OpenMP][NFC] Refresh stale entry-layout comments in mapper codegen test

The per-element entry list described the pre-attach-style codegen: it
listed four entries instead of five, ordered the combined entry before
the s2.z one, used MEMBER_OF(N+1) where MEMBER_OF(N+2) is emitted, and
marked the s1p->x/y entries PTR_AND_OBJ. It also carried a FIXME asking
for the attach-style codegen that is now in place.

Update it to the entries actually emitted, verified against the IR and
the test's own CHECK lines, and drop the obsolete FIXME. Also fix the
comment in foo(), which listed a single top-level entry when there are
two (the mapped array plus its ATTACH entry, per .offload_maptypes).

Comments only; no functional change.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list