[all-commits] [llvm/llvm-project] 8fbdc8: If the address of the isa_pointer is returned as a...

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8fbdc8cd027176fb54c5fbcd7688fe78eed0154f
      https://github.com/llvm/llvm-project/commit/8fbdc8cd027176fb54c5fbcd7688fe78eed0154f
  Author: jimingham <jingham at apple.com>
  Date:   2026-07-30 (Thu, 30 Jul 2026)

  Changed paths:
    M lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

  Log Message:
  -----------
  If the address of the isa_pointer is returned as an error don't ask if it is a tagged pointer (#213163)

The answer isn't right and the wrong type might stick and cause
downstream failures.

Note, the correct solution to this is to distinguish between "couldn't
get the address" and "got a real value of LLDB_INVALID_ADDRESS" but
piping an optional all the way down and then through all the uses is an
intrusive change which I don't have time for right now. That only risk
is that this really IS a tagged pointer with the value
LLDB_INVALID_ADDRESS, so this seems an acceptable workaround.

I ran across this when debugging the ObjC test failures in the ObjC
testuite after 8b9cce358bef26ae4cb9275dd6a43f903bafbaa0. This patch
clears up all those testsuite failures, which should stand as a test for
this patch when I resubmit that change.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications