[all-commits] [llvm/llvm-project] 64bc00: braces

Maksim Levental via All-commits all-commits at lists.llvm.org
Thu Jul 23 16:05:11 PDT 2026


  Branch: refs/heads/users/makslevental/mlir-c-operation-get-parent-with-name
  Home:   https://github.com/llvm/llvm-project
  Commit: 64bc0065055be6cd9d9008248f7321e886ab73b0
      https://github.com/llvm/llvm-project/commit/64bc0065055be6cd9d9008248f7321e886ab73b0
  Author: makslevental <maksim.levental at gmail.com>
  Date:   2026-07-23 (Thu, 23 Jul 2026)

  Changed paths:
    M mlir/lib/CAPI/IR/IR.cpp

  Log Message:
  -----------
  braces

The 1:N conversion callback returned MlirLogicalResult, which the binding
could only map to success or nullopt (try-another), leaving the C++
failure() state (fail without trying another conversion) unreachable.

Return a MlirTypeConverterConversionStatus enum instead, with Success,
Failure, and Declined states mapped to success(), failure(), and
std::nullopt respectively. Add a test covering the hard-failure path.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list