[all-commits] [llvm/llvm-project] 4584a6: [lldb][AArch64][NFC] Make watchpoint adjustment mo...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4584a6489341b4fe7762991e65f98467ffe4c699
      https://github.com/llvm/llvm-project/commit/4584a6489341b4fe7762991e65f98467ffe4c699
  Author: David Spickett <david.spickett at arm.com>
  Date:   2026-07-15 (Wed, 15 Jul 2026)

  Changed paths:
    M lldb/source/Plugins/Process/Utility/NativeRegisterContextDBReg_arm64.cpp

  Log Message:
  -----------
  [lldb][AArch64][NFC] Make watchpoint adjustment more clear (#209483)

NativeRegisterContextDBReg_arm64::AdjustWatchpoint has a way of
adjusting the range of a watchpoint but it took me a while to figure out
how it worked. I've rewritten it in a way I think is easier to follow,
with more explanatory comments.

It turns out that this adjustment results in us only using a subset of
what the hardware allows.
* You don't have to select a continuous range of bytes (1, 2, 3). You
can select (1, 4) for example.
* The address can be 4 byte aligned, in which case only 4 bits of the
byte select apply (though you can set up an equivalent watch with 8 byte
alignment and a different 8 bit BAS value).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications