[all-commits] [llvm/llvm-project] 3ae8e3: [orc-rt] Make noDispatch test helper fail in -Asse...

[Lang Hames via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3ae8e355a288a8306bae6cd3ce635ce3de4a1359
      https://github.com/llvm/llvm-project/commit/3ae8e355a288a8306bae6cd3ce635ce3de4a1359
  Author: Lang Hames <lhames at gmail.com>
  Date:   2026-07-15 (Wed, 15 Jul 2026)

  Changed paths:
    M orc-rt/test/unit/CommonTestUtils.h

  Log Message:
  -----------
  [orc-rt] Make noDispatch test helper fail in -Asserts builds. (#209493)

noDispatch guards Sessions that must never dispatch a wrapper call, but
it did so with assert(false), which compiles out under NDEBUG.

Replace the assert with ADD_FAILURE(), which records a failure in every
build mode, and then complete the call via its Return continuation with
an out-of-band error. Completing the call means a caller awaiting the
result unblocks and fails too, rather than hanging, even when the
dispatch arrives on a non-test thread where ADD_FAILURE() alone may not
be observed.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications