[all-commits] [llvm/llvm-project] b26c41: [InlineCost] Drop Requirements around ByVal Arguments

Aiden Grossman via All-commits all-commits at lists.llvm.org
Tue Jul 14 06:14:26 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b26c417dd887aec06f4a09cd23a979b705c59fa2
      https://github.com/llvm/llvm-project/commit/b26c417dd887aec06f4a09cd23a979b705c59fa2
  Author: Aiden Grossman <aidengrossman at google.com>
  Date:   2026-07-14 (Tue, 14 Jul 2026)

  Changed paths:
    M llvm/lib/Analysis/InlineCost.cpp
    M llvm/test/Transforms/Inline/byval.ll

  Log Message:
  -----------
  [InlineCost] Drop Requirements around ByVal Arguments

The underlying behavior was fixed in
e47359a925b88cd081ea85d10b55b0625d17b212, but given that the example
was marked alwaysinline, it bypassed any legality checks it would have
otherwise hit.

See
https://github.com/llvm/llvm-project/pull/97306#discussion_r1679306183
for discussion around which address space we should be using/legality.

This is necessary to preserve the behavior in
byval-with-non-alloca-addrspace.ll after we enable function attribute
compatibility checks in always-inline.

Reviewers: aeubanks, nikic, arsenm

Pull Request: https://github.com/llvm/llvm-project/pull/209344



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list