[all-commits] [llvm/llvm-project] 63ee25: clang-linker-wrapper: Add additional amdgpu device...

[Matt Arsenault via All-commits]

  Branch: refs/heads/users/arsenm/linker-wrapper-amdgpu-exact-match-tests
  Home:   https://github.com/llvm/llvm-project
  Commit: 63ee25b47f24fa72d563b9034cc6dadfecbb4909
      https://github.com/llvm/llvm-project/commit/63ee25b47f24fa72d563b9034cc6dadfecbb4909
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2026-07-14 (Tue, 14 Jul 2026)

  Changed paths:
    M clang/test/OffloadTools/clang-linker-wrapper/linker-wrapper.c

  Log Message:
  -----------
  clang-linker-wrapper: Add additional amdgpu device merging tests

Regression test for case that caused dc1273beba1c70cb74d03c760958ee625d8aecf5
to be reverted. The relevant case is AMD-DISTINCT-PROC; gfx900 and gfx9-generic
should not be merged into a single image. Also test the sramecc handling, which
was not covered in this test (only xnack was).

I'm confused about what the behavior here is supposed to be. The treatment
of the base arch and the feature modifiers are inconsistent with each other.
The base processor is treated as requiring exact match, but the modifiers
are treated as logical linking.

e.g., xnack+ and xnack-any are logically merged into assuming xnack+.

It just so happens that clang errors if your compile invocation involves
the feature-any and a feature[+-] for the same processor (e.g.,
--offload-arch=gfx90a:xnack+ --offload-arch=gfx90a is an error). It would
be more consistent if the features had to exactly match.

Co-authored-by: Claude (Opus 4.8)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications