[all-commits] [llvm/llvm-project] d6c5e9: [clang][AMDGPU] Clean-up handling of named barrier...

Tue Jul 14 01:25:14 PDT 2026

  Branch: refs/heads/users/pierre-vh/add-hipbarrier-langas
  Home:   https://github.com/llvm/llvm-project
  Commit: d6c5e9596b6bea72d4de14a4aba9c68889b4a8e8
      https://github.com/llvm/llvm-project/commit/d6c5e9596b6bea72d4de14a4aba9c68889b4a8e8
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-14 (Tue, 14 Jul 2026)

  Changed paths:
    M clang/include/clang/AST/TypeBase.h
    M clang/include/clang/Basic/AddressSpaces.h
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/AST/Type.cpp
    M clang/lib/AST/TypePrinter.cpp
    M clang/lib/Basic/TargetInfo.cpp
    M clang/lib/Basic/Targets/AArch64.h
    M clang/lib/Basic/Targets/AMDGPU.cpp
    M clang/lib/Basic/Targets/DirectX.h
    M clang/lib/Basic/Targets/NVPTX.h
    M clang/lib/Basic/Targets/SPIR.h
    M clang/lib/Basic/Targets/SystemZ.h
    M clang/lib/Basic/Targets/TCE.h
    M clang/lib/Basic/Targets/WebAssembly.h
    M clang/lib/Basic/Targets/X86.h
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/lib/Sema/SemaDecl.cpp
    M clang/test/CodeGenHIP/amdgpu-barrier-type.hip
    M clang/test/SemaCXX/amdgpu-barrier.cpp
    M clang/test/SemaHIP/amdgpu-barrier.hip
    M clang/test/SemaOpenCL/amdgpu-barrier.cl
    M clang/test/SemaTemplate/address_space-dependent.cpp

  Log Message:
  -----------
  [clang][AMDGPU] Clean-up handling of named barrier type

- Do not allow the type in struct fields. This is more like a handle/resource than a real type. It does not follow the traditional C++ object model, and using it in a struct field can do some weird things if you instantiate too many of them.
- Use a `hip_barrier` LangAS for this type that currently maps to the local AS. This allows easy switching to the barrier AS in a future patch.

Alternative to #195612, see also #195613


  Commit: d1aa3046a92ef07673b2fe890c6e2f9e2f8d3bd5
      https://github.com/llvm/llvm-project/commit/d1aa3046a92ef07673b2fe890c6e2f9e2f8d3bd5
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-14 (Tue, 14 Jul 2026)

  Changed paths:
    M clang/include/clang/Basic/AddressSpaces.h
    M clang/lib/AST/Type.cpp
    M clang/lib/AST/TypePrinter.cpp
    M clang/lib/Basic/TargetInfo.cpp
    M clang/lib/Basic/Targets/AArch64.h
    M clang/lib/Basic/Targets/AMDGPU.cpp
    M clang/lib/Basic/Targets/DirectX.h
    M clang/lib/Basic/Targets/NVPTX.h
    M clang/lib/Basic/Targets/SPIR.h
    M clang/lib/Basic/Targets/SystemZ.h
    M clang/lib/Basic/Targets/TCE.h
    M clang/lib/Basic/Targets/WebAssembly.h
    M clang/lib/Basic/Targets/X86.h
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/test/SemaCXX/amdgpu-barrier.cpp
    M clang/test/SemaHIP/amdgpu-barrier.hip
    M clang/test/SemaOpenCL/amdgpu-barrier.cl

  Log Message:
  -----------
  Address Comments


  Commit: 485dfab52312fe60674e9dbd3c212446d5024f01
      https://github.com/llvm/llvm-project/commit/485dfab52312fe60674e9dbd3c212446d5024f01
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-14 (Tue, 14 Jul 2026)

  Changed paths:
    M clang/include/clang/AST/TypeBase.h
    M clang/include/clang/Basic/Attr.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/include/clang/Sema/SemaAMDGPU.h
    M clang/lib/AST/Type.cpp
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/lib/Sema/SemaAMDGPU.cpp
    M clang/lib/Sema/SemaDecl.cpp
    M clang/test/CodeGenHIP/amdgpu-barrier-type.hip
    M clang/test/SemaCXX/amdgpu-barrier.cpp
    M clang/test/SemaHIP/amdgpu-barrier.hip
    M clang/test/SemaOpenCL/amdgpu-barrier.cl

  Log Message:
  -----------
  Re-allow wrappers around named barriers


  Commit: 6f7da879a5df4d35d9449947dc99a792bf962138
      https://github.com/llvm/llvm-project/commit/6f7da879a5df4d35d9449947dc99a792bf962138
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-14 (Tue, 14 Jul 2026)

  Changed paths:
    M clang/test/SemaCXX/amdgpu-barrier.cpp
    M clang/test/SemaHIP/amdgpu-barrier.hip

  Log Message:
  -----------
  Add test w/ static field


  Commit: 5d63163301ea05458bbb1c3480d3845ffedc6594
      https://github.com/llvm/llvm-project/commit/5d63163301ea05458bbb1c3480d3845ffedc6594
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-14 (Tue, 14 Jul 2026)

  Changed paths:
    M clang/include/clang/Basic/Attr.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Sema/SemaAMDGPU.cpp
    M clang/lib/Sema/SemaDeclCXX.cpp
    M clang/test/CodeGenHIP/amdgpu-barrier-type.hip
    M clang/test/SemaCXX/amdgpu-barrier.cpp
    M clang/test/SemaHIP/amdgpu-barrier.hip
    M clang/test/SemaOpenCL/amdgpu-barrier.cl

  Log Message:
  -----------
  Update implementation


  Commit: e635600239b55026add5da1949afc34217cefafa
      https://github.com/llvm/llvm-project/commit/e635600239b55026add5da1949afc34217cefafa
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-14 (Tue, 14 Jul 2026)

  Changed paths:
    M clang/include/clang/Basic/Attr.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Sema/SemaAMDGPU.cpp
    M clang/lib/Sema/SemaDeclCXX.cpp
    M clang/test/SemaCXX/amdgpu-barrier.cpp
    M clang/test/SemaHIP/amdgpu-barrier.hip
    M clang/test/SemaOpenCL/amdgpu-barrier.cl

  Log Message:
  -----------
  Use C++ standard layout instead


  Commit: 759c836d0307e10df776e0f4ce313fc47648cc1e
      https://github.com/llvm/llvm-project/commit/759c836d0307e10df776e0f4ce313fc47648cc1e
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-14 (Tue, 14 Jul 2026)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Sema/SemaDecl.cpp

  Log Message:
  -----------
  Revert earlier change


  Commit: 7aa957e06ae575c73b3f3f3f80d41a17af1c7c82
      https://github.com/llvm/llvm-project/commit/7aa957e06ae575c73b3f3f3f80d41a17af1c7c82
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-14 (Tue, 14 Jul 2026)

  Changed paths:
    M clang/include/clang/Basic/TargetInfo.h
    M clang/lib/AST/ASTContext.cpp
    M clang/lib/Basic/TargetInfo.cpp
    M clang/lib/Basic/Targets/AMDGPU.cpp
    M clang/lib/Basic/Targets/SPIR.h
    M clang/lib/Sema/Sema.cpp
    M clang/lib/Sema/SemaAMDGPU.cpp

  Log Message:
  -----------
  Factor out check for AMDGPU types so it can be reused.


  Commit: 52244d568d43b8b7c3a5c7a1fec5a151b693b3fc
      https://github.com/llvm/llvm-project/commit/52244d568d43b8b7c3a5c7a1fec5a151b693b3fc
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-14 (Tue, 14 Jul 2026)

  Changed paths:
    M clang/test/SemaCXX/amdgpu-barrier.cpp
    M clang/test/SemaOpenCL/amdgpu-barrier.cl

  Log Message:
  -----------
  Add RUN lines to check Sema check works if AMDGCN is aux target


  Commit: 5a57601527625e8c49a43008a45cea0319838549
      https://github.com/llvm/llvm-project/commit/5a57601527625e8c49a43008a45cea0319838549
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-14 (Tue, 14 Jul 2026)

  Changed paths:
    M clang/include/clang/Basic/TargetInfo.h
    M clang/lib/Basic/TargetInfo.cpp
    M clang/lib/Basic/Targets/SPIR.h
    M clang/test/CodeGenHIP/amdgpu-barrier-type.hip
    M clang/test/SemaCXX/amdgpu-barrier.cpp
    M clang/test/SemaOpenCL/amdgpu-barrier.cl

  Log Message:
  -----------
  Address Comments


Compare: https://github.com/llvm/llvm-project/compare/fbb063805463...5a5760152762

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications