[all-commits] [llvm/llvm-project] 276dd4: [flang][OpenMP] Address post-merge feedback for me...

Chi-Chun, Chen via All-commits all-commits at lists.llvm.org
Mon Jul 13 10:09:16 PDT 2026


  Branch: refs/heads/users/cchen/flang-metadirective-sema-loop-post-merge
  Home:   https://github.com/llvm/llvm-project
  Commit: 276dd42ddd80414ce2c248f56392b9baaac3a73c
      https://github.com/llvm/llvm-project/commit/276dd42ddd80414ce2c248f56392b9baaac3a73c
  Author: Chi Chun, Chen <chichun.chen at hpe.com>
  Date:   2026-07-13 (Mon, 13 Jul 2026)

  Changed paths:
    M flang/include/flang/Semantics/openmp-utils.h
    M flang/lib/Semantics/check-omp-structure.cpp
    M flang/lib/Semantics/check-omp-structure.h
    M flang/lib/Semantics/check-omp-variant.cpp
    M flang/lib/Semantics/openmp-utils.cpp
    M flang/test/Semantics/OpenMP/metadirective-loop-nest.f90

  Log Message:
  -----------
  [flang][OpenMP] Address post-merge feedback for metadirective loop-nest checks

Address post-merge feedback for #207088.

- Rename mayVariantBeSelected to MayVariantBeSelected and move it from
  check-omp-variant.cpp into the shared openmp-utils so declare-variant
  checking can reuse it.

- Explain why the WHEN clause records its context selector only when the
  modifier list holds exactly one modifier.

- Diagnose a loop-associated metadirective variant in a declaration-only
  program unit (e.g. a module specification part). Such a unit has no
  execution part whose first construct could be the associated loop nest,
  so any variants still pending at the end of the program unit are now
  validated instead of silently ignored. Add a Semantics test for the
  module case.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list