[all-commits] [llvm/llvm-project] 19b08c: [clang][AMDGPU] Clean-up handling of named barrier...

Mon Jul 13 08:00:28 PDT 2026

  Branch: refs/heads/users/pierre-vh/add-hipbarrier-langas
  Home:   https://github.com/llvm/llvm-project
  Commit: 19b08ca9deda56689f1db6e27db0eacb4c9fc819
      https://github.com/llvm/llvm-project/commit/19b08ca9deda56689f1db6e27db0eacb4c9fc819
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-13 (Mon, 13 Jul 2026)

  Changed paths:
    M clang/include/clang/AST/TypeBase.h
    M clang/include/clang/Basic/AddressSpaces.h
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/AST/Type.cpp
    M clang/lib/AST/TypePrinter.cpp
    M clang/lib/Basic/TargetInfo.cpp
    M clang/lib/Basic/Targets/AArch64.h
    M clang/lib/Basic/Targets/AMDGPU.cpp
    M clang/lib/Basic/Targets/DirectX.h
    M clang/lib/Basic/Targets/NVPTX.h
    M clang/lib/Basic/Targets/SPIR.h
    M clang/lib/Basic/Targets/SystemZ.h
    M clang/lib/Basic/Targets/TCE.h
    M clang/lib/Basic/Targets/WebAssembly.h
    M clang/lib/Basic/Targets/X86.h
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/lib/Sema/SemaDecl.cpp
    M clang/test/CodeGenHIP/amdgpu-barrier-type.hip
    M clang/test/SemaCXX/amdgpu-barrier.cpp
    M clang/test/SemaHIP/amdgpu-barrier.hip
    M clang/test/SemaOpenCL/amdgpu-barrier.cl
    M clang/test/SemaTemplate/address_space-dependent.cpp

  Log Message:
  -----------
  [clang][AMDGPU] Clean-up handling of named barrier type

- Do not allow the type in struct fields. This is more like a handle/resource than a real type. It does not follow the traditional C++ object model, and using it in a struct field can do some weird things if you instantiate too many of them.
- Use a `hip_barrier` LangAS for this type that currently maps to the local AS. This allows easy switching to the barrier AS in a future patch.

Alternative to #195612, see also #195613


  Commit: 1de6f77f031e809c14d9b35d763a7688c6cfca44
      https://github.com/llvm/llvm-project/commit/1de6f77f031e809c14d9b35d763a7688c6cfca44
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-13 (Mon, 13 Jul 2026)

  Changed paths:
    M clang/include/clang/Basic/AddressSpaces.h
    M clang/lib/AST/Type.cpp
    M clang/lib/AST/TypePrinter.cpp
    M clang/lib/Basic/TargetInfo.cpp
    M clang/lib/Basic/Targets/AArch64.h
    M clang/lib/Basic/Targets/AMDGPU.cpp
    M clang/lib/Basic/Targets/DirectX.h
    M clang/lib/Basic/Targets/NVPTX.h
    M clang/lib/Basic/Targets/SPIR.h
    M clang/lib/Basic/Targets/SystemZ.h
    M clang/lib/Basic/Targets/TCE.h
    M clang/lib/Basic/Targets/WebAssembly.h
    M clang/lib/Basic/Targets/X86.h
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/test/SemaCXX/amdgpu-barrier.cpp
    M clang/test/SemaHIP/amdgpu-barrier.hip
    M clang/test/SemaOpenCL/amdgpu-barrier.cl

  Log Message:
  -----------
  Address Comments


  Commit: 72c6559899a6bfe5214ec23badeffebdff9581ea
      https://github.com/llvm/llvm-project/commit/72c6559899a6bfe5214ec23badeffebdff9581ea
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-13 (Mon, 13 Jul 2026)

  Changed paths:
    M clang/include/clang/AST/TypeBase.h
    M clang/include/clang/Basic/Attr.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/include/clang/Sema/SemaAMDGPU.h
    M clang/lib/AST/Type.cpp
    M clang/lib/CodeGen/CodeGenModule.cpp
    M clang/lib/Sema/SemaAMDGPU.cpp
    M clang/lib/Sema/SemaDecl.cpp
    M clang/test/CodeGenHIP/amdgpu-barrier-type.hip
    M clang/test/SemaCXX/amdgpu-barrier.cpp
    M clang/test/SemaHIP/amdgpu-barrier.hip
    M clang/test/SemaOpenCL/amdgpu-barrier.cl

  Log Message:
  -----------
  Re-allow wrappers around named barriers


  Commit: ed47c3537766efd78c67173e1c557973c61ddca0
      https://github.com/llvm/llvm-project/commit/ed47c3537766efd78c67173e1c557973c61ddca0
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-13 (Mon, 13 Jul 2026)

  Changed paths:
    M clang/test/SemaCXX/amdgpu-barrier.cpp
    M clang/test/SemaHIP/amdgpu-barrier.hip

  Log Message:
  -----------
  Add test w/ static field


  Commit: 67682530faaa16a4095d10d5bae86382e2056c1a
      https://github.com/llvm/llvm-project/commit/67682530faaa16a4095d10d5bae86382e2056c1a
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-13 (Mon, 13 Jul 2026)

  Changed paths:
    M clang/include/clang/Basic/Attr.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Sema/SemaAMDGPU.cpp
    M clang/lib/Sema/SemaDeclCXX.cpp
    M clang/test/CodeGenHIP/amdgpu-barrier-type.hip
    M clang/test/SemaCXX/amdgpu-barrier.cpp
    M clang/test/SemaHIP/amdgpu-barrier.hip
    M clang/test/SemaOpenCL/amdgpu-barrier.cl

  Log Message:
  -----------
  Update implementation


  Commit: e33304c3d59c8eddc5b447eb83ff4053414f8a39
      https://github.com/llvm/llvm-project/commit/e33304c3d59c8eddc5b447eb83ff4053414f8a39
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-13 (Mon, 13 Jul 2026)

  Changed paths:
    M clang/include/clang/Basic/Attr.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Sema/SemaAMDGPU.cpp
    M clang/lib/Sema/SemaDeclCXX.cpp
    M clang/test/SemaCXX/amdgpu-barrier.cpp
    M clang/test/SemaHIP/amdgpu-barrier.hip
    M clang/test/SemaOpenCL/amdgpu-barrier.cl

  Log Message:
  -----------
  Use C++ standard layout instead


  Commit: 64b76dca15efbcad71d96cfa2a11f6368b67714f
      https://github.com/llvm/llvm-project/commit/64b76dca15efbcad71d96cfa2a11f6368b67714f
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-13 (Mon, 13 Jul 2026)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/Sema/SemaDecl.cpp

  Log Message:
  -----------
  Revert earlier change


  Commit: d387f72a80d647dbb6bdcc02401ac810a288217a
      https://github.com/llvm/llvm-project/commit/d387f72a80d647dbb6bdcc02401ac810a288217a
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-13 (Mon, 13 Jul 2026)

  Changed paths:
    M clang/include/clang/Basic/TargetInfo.h
    M clang/lib/AST/ASTContext.cpp
    M clang/lib/Basic/TargetInfo.cpp
    M clang/lib/Basic/Targets/AMDGPU.cpp
    M clang/lib/Basic/Targets/SPIR.h
    M clang/lib/Sema/Sema.cpp
    M clang/lib/Sema/SemaAMDGPU.cpp

  Log Message:
  -----------
  Factor out check for AMDGPU types so it can be reused.


  Commit: bb668ba0810c4d3c172f1c540aa4540e4a433520
      https://github.com/llvm/llvm-project/commit/bb668ba0810c4d3c172f1c540aa4540e4a433520
  Author: pvanhout <pierre.vanhoutryve at amd.com>
  Date:   2026-07-13 (Mon, 13 Jul 2026)

  Changed paths:
    M clang/test/SemaCXX/amdgpu-barrier.cpp
    M clang/test/SemaOpenCL/amdgpu-barrier.cl

  Log Message:
  -----------
  Add RUN lines to check Sema check works if AMDGCN is aux target


Compare: https://github.com/llvm/llvm-project/compare/6c93213b4753...bb668ba0810c

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications