[all-commits] [llvm/llvm-project] c31455: [libc++] Fix filesystem::remove_all bug with read-...

[Jake Egan via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c31455cd07c43ed02445f5b1f1057037f0503552
      https://github.com/llvm/llvm-project/commit/c31455cd07c43ed02445f5b1f1057037f0503552
  Author: Jake Egan <Jake.egan at ibm.com>
  Date:   2026-07-13 (Mon, 13 Jul 2026)

  Changed paths:
    M libcxx/src/filesystem/operations.cpp
    A libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.remove_all/bad_perms_parent.pass.cpp

  Log Message:
  -----------
  [libc++] Fix filesystem::remove_all bug with read-only nested directory (#197104)

Consider a directory `parent/child`, where `parent` has read-only
permissions. Calling `remove_all` on `parent` is expected to fail with a
permission error, however it fails with a different error depending on
the platform (such as "error file exists" on AIX).

During the recursive removal, `unlinkat` is first called on the child
and fails with a permission error. Rather than returning, the function
continues and tries `unlinkat` on the parent and fails with a different
error depending on the platform. This error is returned instead of the
permission error. This PR makes the first encountered error be returned
instead.

According to the standard [fs.op.remove.all]:
> Effects: Recursively deletes the contents of p if it exists, then
> deletes file p itself, as if by POSIX remove.

The word "then" implies an ordering where deleting the contents of p
should be successful before deleting file p itself.

Fixes #197100.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications