[all-commits] [llvm/llvm-project] 88c1f9: [CodeGen] Fix incorrect rematerialization rollback...
Lucas Ramirez via All-commits
all-commits at lists.llvm.org
Mon Jul 13 03:17:13 PDT 2026
Branch: refs/heads/users/lucas-rami/rematerializer-fix-rollback-order
Home: https://github.com/llvm/llvm-project
Commit: 88c1f9d6772ee3087fdbb323fe7e5422cddacbbf
https://github.com/llvm/llvm-project/commit/88c1f9d6772ee3087fdbb323fe7e5422cddacbbf
Author: Lucas Ramirez <lucas.rami at proton.me>
Date: 2026-07-13 (Mon, 13 Jul 2026)
Changed paths:
M llvm/include/llvm/CodeGen/Rematerializer.h
M llvm/lib/CodeGen/Rematerializer.cpp
M llvm/unittests/CodeGen/RematerializerTest.cpp
Log Message:
-----------
[CodeGen] Fix incorrect rematerialization rollback order
This fixes an issue in the rematerializer's rollbacker wherein adjacent
MIs that were deleted through rematerializations would
sometimes---depending on the exact order in which they were
deleted---not be re-created in their original
pre-rematerialization order. While this does not impact correctness
(i.e., use-def relations are always honored), this goes against the
rollbacker's intent to re-create the MIR exactly as it was
pre-rematerializations (up to slot index changes).
Commit: 34e390b9dc42a9c9b51c68df6e7e46cad413cb87
https://github.com/llvm/llvm-project/commit/34e390b9dc42a9c9b51c68df6e7e46cad413cb87
Author: Lucas Ramirez <lucas.rami at proton.me>
Date: 2026-07-13 (Mon, 13 Jul 2026)
Changed paths:
M llvm/include/llvm/CodeGen/Rematerializer.h
M llvm/lib/CodeGen/Rematerializer.cpp
M llvm/unittests/CodeGen/RematerializerTest.cpp
Log Message:
-----------
Change rollback method to reduce tracking need
Commit: 217d8da2d8433f80e5efda14c30d5eff9a457248
https://github.com/llvm/llvm-project/commit/217d8da2d8433f80e5efda14c30d5eff9a457248
Author: Lucas Ramirez <lucas.rami at proton.me>
Date: 2026-07-13 (Mon, 13 Jul 2026)
Changed paths:
M llvm/include/llvm/CodeGen/Rematerializer.h
M llvm/lib/CodeGen/Rematerializer.cpp
M llvm/unittests/CodeGen/RematerializerTest.cpp
Log Message:
-----------
Use a union instead of void* + static_cast for InsertBeforePos
Compare: https://github.com/llvm/llvm-project/compare/d6b5e8f71674...217d8da2d843
To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications
More information about the All-commits
mailing list