[all-commits] [llvm/llvm-project] 053827: [lldb] Don't add the same module to a target twice...

[Charles Zablit via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0538275eca10798aa0d0dd6261f11fbc7cc9e99e
      https://github.com/llvm/llvm-project/commit/0538275eca10798aa0d0dd6261f11fbc7cc9e99e
  Author: Charles Zablit <c_zablit at apple.com>
  Date:   2026-07-09 (Thu, 09 Jul 2026)

  Changed paths:
    M lldb/source/Target/Target.cpp

  Log Message:
  -----------
  [lldb] Don't add the same module to a target twice (#208472)

`Target::GetOrCreateModule` uses `Append`, so a module already in the
target could be added again. Then `RemoveModule` dropped only one,
keeping the module (and its memory-mapped file) alive.
On Windows that mapped file can't be deleted, causing
`TestReplaceDLL.py` to fail with `LLDB_USE_LLDB_SERVER=1`.

This patch uses `AppendIfNeeded` instead.

rdar://181797592



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications