[all-commits] [llvm/llvm-project] 63122f: [NFC][ELF] Don't reimplement addReloc in MipsGotSe...

[Jessica Clarke via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 63122f54df24161899609449e92589f3db556bf4
      https://github.com/llvm/llvm-project/commit/63122f54df24161899609449e92589f3db556bf4
  Author: Jessica Clarke <jrtc27 at jrtc27.com>
  Date:   2026-07-08 (Wed, 08 Jul 2026)

  Changed paths:
    M lld/ELF/SyntheticSections.cpp
    M lld/ELF/SyntheticSections.h

  Log Message:
  -----------
  [NFC][ELF] Don't reimplement addReloc in MipsGotSection::addConstant (#208130)

This is a repeat of d48eb719d240 ("[NFC][ELF] Don't reimplement addReloc
in GotSection::addConstant") but for MipsGotSection. Unfortunately,
9fb61d972213 ("[NFCI][ELF][Mips] Refactor MipsGotSection to avoid
explicit writes (#178561)") was put up for review before, and was landed
after, that commit, and I did not think to update it, so it ended up
copying the old GotSection code. Although there's no motivation to
support CHERI in this code (even though CHERI-MIPS existed it never used
the highly-specialised MipsGotSection to hold capabilities), it's still
better to use our own abstractions, and to be consistent.

Fixes: 9fb61d972213 ("[NFCI][ELF][Mips] Refactor MipsGotSection to avoid
explicit writes (#178561)")



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications