[all-commits] [llvm/llvm-project] 67f0c1: [mlir][OpenMP] Change device declare target functi...
Robert Imschweiler via All-commits
all-commits at lists.llvm.org
Thu Jul 2 10:14:14 PDT 2026
Branch: refs/heads/users/ro-i/omp-device-declare-target-hidden-visibility
Home: https://github.com/llvm/llvm-project
Commit: 67f0c1e7ca0ae51ae84ba93f6cb50f1cd760c827
https://github.com/llvm/llvm-project/commit/67f0c1e7ca0ae51ae84ba93f6cb50f1cd760c827
Author: Robert Imschweiler <robert.imschweiler at amd.com>
Date: 2026-07-02 (Thu, 02 Jul 2026)
Changed paths:
M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
A mlir/test/Target/LLVMIR/omptarget-declare-target-func-visibility.mlir
M mlir/test/Target/LLVMIR/omptarget-device-shared-mem.mlir
M mlir/test/Target/LLVMIR/omptarget-wsloop-collapsed.mlir
M mlir/test/Target/LLVMIR/omptarget-wsloop.mlir
M mlir/test/Target/LLVMIR/openmp-llvm.mlir
Log Message:
-----------
[mlir][OpenMP] Change device declare target functions to hidden visibility
During OpenMP lowering, globally visible device functions are emitted.
These functions might not be kernels themselves, but are designed to
only be called in a kernel context. However, if they are unused, and not
inlined, and reference LDS, the AMDGPU ISel emits lots of misleading
warnings related to "local memory global used by non-kernel function".
Fix by changing visibility from external+default to external+hidden,
which allows DCE to just remove the functions.
Claude assisted with this patch.
To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications
More information about the All-commits
mailing list