[all-commits] [llvm/llvm-project] 049448: [NFC][lldb] Split DomainSocket into a base + posix...

Charles Zablit via All-commits all-commits at lists.llvm.org
Fri Jun 26 09:57:52 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 049448403c7bfd140a212aefe3c422f3cad810ce
      https://github.com/llvm/llvm-project/commit/049448403c7bfd140a212aefe3c422f3cad810ce
  Author: Charles Zablit <c_zablit at apple.com>
  Date:   2026-06-26 (Fri, 26 Jun 2026)

  Changed paths:
    A lldb/include/lldb/Host/DomainSocket.h
    A lldb/include/lldb/Host/common/DomainSocket.h
    M lldb/include/lldb/Host/linux/AbstractSocket.h
    R lldb/include/lldb/Host/posix/DomainSocket.h
    A lldb/include/lldb/Host/posix/DomainSocketPosix.h
    A lldb/include/lldb/Host/windows/DomainSocketWindows.h
    M lldb/source/Host/CMakeLists.txt
    A lldb/source/Host/common/DomainSocket.cpp
    M lldb/source/Host/common/Socket.cpp
    R lldb/source/Host/posix/DomainSocket.cpp
    A lldb/source/Host/posix/DomainSocketPosix.cpp
    A lldb/source/Host/windows/DomainSocketWindows.cpp
    M lldb/tools/lldb-server/lldb-platform.cpp
    M lldb/unittests/TestingSupport/Host/SocketTestUtilities.h

  Log Message:
  -----------
  [NFC][lldb] Split DomainSocket into a base + posix/windows impls (#205864)

Prepares for `AF_UNIX` domain-socket support on Windows by separating
the cross-platform socket logic from the one platform-specific
operation.

Every domain-socket operation is identical on POSIX and Windows (via
`<afunix.h>`), so it now lives in a single base class
`DomainSocket`. The one operation that is different is `CreatePair()`.
It lives in `DomainSocketPosix` / `DomainSocketWindows`. It's selected
for the host as `DomainSocketPlatform` through
`lldb/Host/DomainSocket.h`.

This is an NFC patch: POSIX behavior is unchanged, and while the shared
code now also compiles on Windows it stays unreachable there. A
follow-up commit enables it.

rdar://180736036



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list