[all-commits] [llvm/llvm-project] 5c561a: [MLIR] Fix broken 'Successor<CPred<...>>' function...

Christopher Bate via All-commits all-commits at lists.llvm.org
Thu Jun 25 11:37:19 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5c561a32a5afccb42b2a44f95535dbe6ea939f44
      https://github.com/llvm/llvm-project/commit/5c561a32a5afccb42b2a44f95535dbe6ea939f44
  Author: Christopher Bate <cbate at nvidia.com>
  Date:   2026-06-25 (Thu, 25 Jun 2026)

  Changed paths:
    M mlir/lib/TableGen/CodeGenHelpers.cpp
    A mlir/test/IR/test-successor-verifier.mlir
    M mlir/test/lib/Dialect/Test/TestOps.td
    M mlir/test/mlir-tblgen/constraint-unique.td
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

  Log Message:
  -----------
  [MLIR] Fix broken 'Successor<CPred<...>>' functionality in mlir-tblgen (#205375)

Previously, mlir-tblgen would generate incorrect C++ code when
passing a custom constraint to `Successor<...>`. The code would fail
to compile. We lacked end-to-end tests for this functionality and all
in-tree dialects only use `AnySuccessor` for their successors.

Custom C++ predicates for an Operation's successor(s) can be useful
in order to generate verification for certain conditions (e.g. that the
successor is the "next" block). This commit fixes the mlir-tblgen
functionality and adds end-to-end tests in the Test dialect for single
and variadic successors.

Assisted-by: Claude



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list