[all-commits] [llvm/llvm-project] 17308a: [orc-rt] Fix assertion, add fail-to-connect unit t...

Lang Hames via All-commits all-commits at lists.llvm.org
Thu Jun 18 20:12:21 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 17308a961710f91e073923405712bacc981c936a
      https://github.com/llvm/llvm-project/commit/17308a961710f91e073923405712bacc981c936a
  Author: Lang Hames <lhames at gmail.com>
  Date:   2026-06-19 (Fri, 19 Jun 2026)

  Changed paths:
    M orc-rt/lib/executor/Session.cpp
    M orc-rt/unittests/SessionTest.cpp

  Log Message:
  -----------
  [orc-rt] Fix assertion, add fail-to-connect unit test. (#204720)

If a ControllerAccess object's connect method calls notifyDisconnected
then by the time we return to Connect we may have completed the detach,
in which case TargetState will be None, and CurrentState will be >=
Detached. This case was not covered by the assert after the return from
connect, leading to assertions when connect failed.

This commit relaxes the assertion to include the case above, and adds a
unit test to cover it.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list