[all-commits] [llvm/llvm-project] 14877f: [clang][AST] Attributed Type Deduplication Logic C...

Qiongsi Wu via All-commits all-commits at lists.llvm.org
Wed Jun 17 08:43:03 PDT 2026


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 14877f950a12e5681d06f2866f05bbfd8d65a0be
      https://github.com/llvm/llvm-project/commit/14877f950a12e5681d06f2866f05bbfd8d65a0be
  Author: Qiongsi Wu <qiongsiwu at gmail.com>
  Date:   2026-06-17 (Wed, 17 Jun 2026)

  Changed paths:
    M clang/lib/AST/AttrImpl.cpp
    M clang/lib/AST/Type.cpp
    M clang/utils/TableGen/ClangAttrEmitter.cpp

  Log Message:
  -----------
  [clang][AST] Attributed Type Deduplication Logic Cleanup (#204263)

https://github.com/llvm/llvm-project/pull/200961 implemented
`AttributedType` deduplication using the attributes' arguments. This PR
addresses the post-commit feedback.

The reason to have `llvm_unreachable("profile not implemented for this
type");` in the body of `profileAttrArg` for non-supported attribute
types is that none of the attributes that currently instantiate this
method are type attributes. The methods that are instantiated and not
supported are all for decl attributes. Leaving the body out will lead to
compilation failures, but the method's body should never be executed. If
an unsupported attribute type happens to execute this code path, the
failure should be loud and clear.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list