[all-commits] [llvm/llvm-project] 86d740: [lldb] Add static asserts on Symbol size to DataFi...

[Jason Molenda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 86d7405f428e0cf4cdeba55babbcd111ab499370
      https://github.com/llvm/llvm-project/commit/86d7405f428e0cf4cdeba55babbcd111ab499370
  Author: Jason Molenda <jmolenda at apple.com>
  Date:   2026-06-14 (Sun, 14 Jun 2026)

  Changed paths:
    M lldb/source/Symbol/Symbol.cpp
    M lldb/source/Symbol/Symtab.cpp

  Log Message:
  -----------
  [lldb] Add static asserts on Symbol size to DataFileCache (#203735)

DataFileCache is a serialization to disk of a Symtab - the symbol names
and array of Symbol objects - so if the contents of the Symbol object
change, the serialization may need to change as well, and we need to
bump the DataFileCache version number to avoid misparsing an older
format.

It's also a little too easy to change Symbol and not notice that
Symbol::Encode/Decode and Symtab::Encode/Decode need to be updated.

static_asserting the size of Symbol isn't perfect, but as long as we're
doing it in Symbol.h already to warn anyone increasing the size of this
object, I want to use the same technique to make sure people look at
these other sites that are tied to the contents.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications