[all-commits] [llvm/llvm-project] 416a7a: clang/AMDGPU: Split out target ID flags in Transla...

[Matt Arsenault via All-commits]

  Branch: refs/heads/users/arsenm/clang/introduce-xnack-sramecc-flags
  Home:   https://github.com/llvm/llvm-project
  Commit: 416a7a8864ec705f36951ae1b09381a0bf474085
      https://github.com/llvm/llvm-project/commit/416a7a8864ec705f36951ae1b09381a0bf474085
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2026-06-14 (Sun, 14 Jun 2026)

  Changed paths:
    M clang/include/clang/Options/Options.td
    M clang/lib/Driver/ToolChains/AMDGPU.cpp
    M clang/lib/Driver/ToolChains/AMDGPU.h
    M clang/lib/Driver/ToolChains/HIPAMD.cpp
    M clang/lib/Driver/ToolChains/HIPAMD.h
    M clang/test/Driver/amdgpu-openmp-toolchain.c
    M clang/test/Driver/amdgpu-toolchain.c
    A clang/test/Driver/amdgpu-xnack-sramecc-flags.c
    M clang/test/Driver/hip-target-id.hip
    M clang/test/Driver/hip-toolchain-features.hip
    M clang/test/Driver/target-id.cl

  Log Message:
  -----------
  clang/AMDGPU: Split out target ID flags in TranslateArgs.

Change how xnack and sramecc are processed. Introduce
-mxnack/-mno-xnack and -msramecc/-mno-sramecc flags.
When the target is first parsed in TranslateArgs, synthesize
the appropriate flag for the toolchain. This avoids
special case feature string fixups in getAMDGPUTargetFeatures,
and also avoids an extra parse of the target ID.

In the future this will also simplify tracking these ABI
modifiers in a module flag.

As a side-effect, you can use these flags to override the
no specifier case with the flags. These do not fully replace
the target ID syntax, as there's no way to represent compiling
both modes for the same subtarget.

I didn't bother trying to forward these flags on the main command
line without being specified to the offload device, but I suppose
that would be possible.

Co-Authored-By: Claude Opus 4.6 <noreply at anthropic.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications